[ 
https://issues.apache.org/jira/browse/LUCENE-6780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14805324#comment-14805324
 ] 

Michael McCandless commented on LUCENE-6780:
--------------------------------------------

I'm still struggling to get {{BKDDistanceQuery}} working here, even with the 
good GeoUtil fixes on this branch.

So I switched back to making the {{GeoUtilsTest}} more evil:

First, I noticed that {{TestGeoUtils}} was always using a tiny lat/lon area 
(1-3 degrees) and fixed that to sometimes be the full range, and then I 
improved the "self consistency" test ({{TestGeoUtils.testGeoRelations}}) to 
stress the {{GeoUtils}} APIs like BKD does, and now there are some fun 
failures, e.g.:

{noformat}
   [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=TestGeoUtils 
-Dtests.method=testGeoRelations -Dtests.seed=48F4A913CBA1095 -Dtests.slow=true 
-Dtests.linedocsfile=/lucenedata/hudson.enwiki.random.lines.txt.fixed 
-Dtests.locale=es_NI -Dtests.timezone=America/Argentina/Salta 
-Dtests.asserts=true -Dtests.file.encoding=UTF-8
   [junit4] FAILURE 0.14s | TestGeoUtils.testGeoRelations <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: 243 incorrect hits 
(see above)
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([48F4A913CBA1095:C6AC5E24484D662B]:0)
   [junit4]    >        at 
org.apache.lucene.util.TestGeoUtils.testGeoRelations(TestGeoUtils.java:509)
   [junit4]    >        at java.lang.Thread.run(Thread.java:745)
{noformat}

If you run with {{-Dtests.verbose=true}} you see lots of diagnostics explaining 
which {{GeoUtils}} API went wrong... in this case, 
{{GeoUtils.rectWithinCircle}} returned true when it should have returned false. 
 Now I need [~nknize]'s help!


> GeoPointDistanceQuery doesn't work with a large radius?
> -------------------------------------------------------
>
>                 Key: LUCENE-6780
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6780
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>         Attachments: LUCENE-6780.patch, LUCENE-6780.patch, LUCENE-6780.patch, 
> LUCENE-6780.patch, LUCENE-6780.patch
>
>
> I'm working on LUCENE-6698 but struggling with test failures ...
> Then I noticed that TestGeoPointQuery's test never tests on large distances, 
> so I modified the test to sometimes do so (like TestBKDTree) and hit test 
> failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to