[
https://issues.apache.org/jira/browse/LUCENE-6650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated LUCENE-6650:
---------------------------------
Attachment: LUCENE-6650.patch
Finally I finished. Filters were used a lot here, particularly in the "prefix"
package. A summary of changes:
* The main high-level API change to put in CHANGES.txt is that
SpatialStrategy.makeFilter doesn't exist any more; people should call makeQuery
which already existed. FYI this abstraction is a facade to details most users
won't see. It's still marked lucene.experimental but arguably it isn't.
* The PrefixTreeStrategy.calcFacets() method (and the internal collaborators
that take the same parameters) doesn't take a Filter now, it has a {{Bits
topAcceptDocs}} instead.
* Any subclasses of Filter had their names changed to reflect Query. These
queries are all lucene.experimental or internal.
* The removal of acceptDocs in LUCENE-6553 meant I could follow-suit in most
places. But the PrefixTreeFacetCounter (used in e.g. heatmap) needs to be
aware of acceptDocs since it's not a Query so just there did I need to keep
that. It worked out fine.
* SerializedDVStrategy's makeQuery no longer throws an exception if you try to
iterate on it versus access it via a matches() on TwoPhaseIterator because it
would be hard/impossible and basically not worthwhile. There's less code there
to implement now any way, thanks to RandomAccessWeight.
* (Not strictly related?) In BBoxStrategy's boolean queries, I substituted
BooleanClause.Occur.FILTER instead of MUST through I'm not sure if it matters?
(score doesn't matter; the whole thing is wrapped in a ConstantScoreQuery).
> Remove dependency of lucene/spatial on oal.search.Filter
> --------------------------------------------------------
>
> Key: LUCENE-6650
> URL: https://issues.apache.org/jira/browse/LUCENE-6650
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Adrien Grand
> Assignee: David Smiley
> Attachments: LUCENE-6650.patch, LUCENE-6650.patch
>
>
> We should try to remove usage of oal.search.Filter in lucene/spatial. I gave
> it a try but this module makes non-trivial use of filters so I wouldn't mind
> some help here.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
