[ 
https://issues.apache.org/jira/browse/SOLR-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14946974#comment-14946974
 ] 

Yonik Seeley commented on SOLR-5944:
------------------------------------

bq. I think, though I may be missing something, the reordered updates would be 
a rare occurrence and the delay for the required update to arrive will be in 
order of milliseconds, and hence there wouldn't be too much of an overhead to 
waiting on those rare occasions.

It's not so rare if multiple clients are updating the same doc.  Milliseconds 
can be pushed to many seconds due to GC, etc.  Also, it gets very tricky if a 
replica goes down...  I haven't thought through that part.  What happens if the 
dependent update fails on one shard?

bq. instead, letting leader threads, carrying out of order updates, to wait 
till the dependent update has been applied on the replica

"leader threads" meaning they are on the leader?  If so, this is sort of where 
I was going before (handling more on the leader)... except instead of detecting 
and waiting for the dependent update, just send the dependent update first 
(i.e. don't reorder).  Seems easier?
Hmmm, but looking at your follow-up, it sounds more like you're blocking on the 
replica?

{quote}
> Don't reorder updates between leader and replicas
This is probably beyond the scope of this ticket.
{quote}

It certainly is beyond the scope of this ticket, but it also would solve a lot 
of issues.  We need to continue to think about any and all approaches to make 
this feature bullet-proof.

Will all "atomic updates" now be handled this way?  Seems desirable in general.

Scanning back over this issue, I happened to see:
bq. 3. Earlier, atomic updates were not carrying forward the non-stored, 
non-indexed docvalues to the new document. Added a fix for this.

If it hasn't been done already, this could be broken out into it's own issue 
and fixed now?

> Support updates of numeric DocValues
> ------------------------------------
>
>                 Key: SOLR-5944
>                 URL: https://issues.apache.org/jira/browse/SOLR-5944
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Ishan Chattopadhyaya
>            Assignee: Shalin Shekhar Mangar
>         Attachments: SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, 
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, 
> SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, SOLR-5944.patch, 
> SOLR-5944.patch
>
>
> LUCENE-5189 introduced support for updates to numeric docvalues. It would be 
> really nice to have Solr support this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to