[
https://issues.apache.org/jira/browse/LUCENE-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless updated LUCENE-6829:
---------------------------------------
Attachment: LUCENE-6829.patch
New patch, I think it's closer:
* The default temp dir logic is now private to Hunspell
* I added Directory.createTempOutput, and also added IndexOutput.getName (so
you can ask what temp name was picked). I use a seed'd random
instance to generate the name candidates, retrying until I get one
that didn't already exist.
* Simplified the OfflineSorter API: the sort method now owns
creating a temp file (sorted), and then returns its name
* Fixed the formatting disaster from TestRandomChains (I blame emacs)
* I cutover to TrackingDirectory in OfflineSorter to manage
"deleting temp files on exception", and simply the
try/finally/success horror show
* I changed TrackingDiretoryWrapper.getCreatedFiles to make a clone
first (it had a TODO about it, and I also hit a cryptic
ConcurrentModificationExc because it didn't clone), and I added an
explicit clearCreatedFiles, used by IW
> OfflineSorter should use Directory API
> --------------------------------------
>
> Key: LUCENE-6829
> URL: https://issues.apache.org/jira/browse/LUCENE-6829
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: Trunk, 5.4
>
> Attachments: LUCENE-6829.patch, LUCENE-6829.patch, LUCENE-6829.patch
>
>
> I think this is a blocker for LUCENE-6825, because the block KD-tree makes
> heavy use of OfflineSorter and we don't want to fill up tmp space ...
> This should be a straightforward cutover, but there are some challenges, e.g.
> the test was failing because virus checker blocked deleting of files.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
