[
https://issues.apache.org/jira/browse/SOLR-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14957797#comment-14957797
]
Christine Poerschke commented on SOLR-8033:
-------------------------------------------
{{TransactionLog}} as the base class of {{HdfsTransactionLog}} has an
equivalent (not commented out) {{log.debug}} statement i.e. perhaps just
removing the commenting out i.e. re-instating the debug log statement is an
alternative to removal of the entire if-statement?
I also notice that the HdfsTransactionLog constructor takes a
{{tlogDfsReplication}} argument and we might wish to include that in a
re-instated debug log statement.
> useless if branch
> -----------------
>
> Key: SOLR-8033
> URL: https://issues.apache.org/jira/browse/SOLR-8033
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 5.0, 5.1
> Reporter: songwanging
> Priority: Minor
>
> In method HdfsTransactionLog() of class HdfsTransactionLog
> (solr\core\src\java\org\apache\solr\update\HdfsTransactionLog.java)
> The if branch presented in the following code snippet performs no actions, we
> should add more code to handle this or directly delete this if branch.
> HdfsTransactionLog(FileSystem fs, Path tlogFile, Collection<String>
> globalStrings, boolean openExisting) {
> ...
> try {
> if (debug) {
> //log.debug("New TransactionLog file=" + tlogFile + ", exists=" +
> tlogFile.exists() + ", size=" + tlogFile.length() + ", openExisting=" +
> openExisting);
> }
> ...
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
