Github user uschindler commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/206#discussion_r42311693
  
    --- Diff: 
solr/contrib/extraction/src/java/org/apache/solr/handler/extraction/ExtractingRequestHandler.java
 ---
    @@ -79,6 +81,20 @@ public void inform(SolrCore core) {
               throw new SolrException(ErrorCode.SERVER_ERROR, e);
             }
           }
    +
    +      String parseContextConfigLoc = (String) 
initArgs.get(PARSE_CONTEXT_CONFIG);
    +      if (parseContextConfigLoc != null) {
    +        File parseContextConfigFile = new File(parseContextConfigLoc);
    +        if (parseContextConfigFile.isAbsolute() == false) {
    +          parseContextConfigFile = new 
File(core.getResourceLoader().getConfigDir(), parseContextConfigFile.getPath());
    +        }
    +        try {
    +          parseContextConfig = new 
ParseContextConfig(parseContextConfigFile, 
core.getResourceLoader().getClassLoader());
    --- End diff --
    
    I would directly pass the resourceloader and not the classloader. 
Resourceloader has easy-to-use methods to load classes, too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to