[
https://issues.apache.org/jira/browse/SOLR-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961999#comment-14961999
]
ASF GitHub Bot commented on SOLR-8166:
--------------------------------------
Github user uschindler commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/206#discussion_r42311693
--- Diff:
solr/contrib/extraction/src/java/org/apache/solr/handler/extraction/ExtractingRequestHandler.java
---
@@ -79,6 +81,20 @@ public void inform(SolrCore core) {
throw new SolrException(ErrorCode.SERVER_ERROR, e);
}
}
+
+ String parseContextConfigLoc = (String)
initArgs.get(PARSE_CONTEXT_CONFIG);
+ if (parseContextConfigLoc != null) {
+ File parseContextConfigFile = new File(parseContextConfigLoc);
+ if (parseContextConfigFile.isAbsolute() == false) {
+ parseContextConfigFile = new
File(core.getResourceLoader().getConfigDir(), parseContextConfigFile.getPath());
+ }
+ try {
+ parseContextConfig = new
ParseContextConfig(parseContextConfigFile,
core.getResourceLoader().getClassLoader());
--- End diff --
I would directly pass the resourceloader and not the classloader.
Resourceloader has easy-to-use methods to load classes, too.
> Introduce possibility to configure ParseContext in
> ExtractingRequestHandler/ExtractingDocumentLoader
> ----------------------------------------------------------------------------------------------------
>
> Key: SOLR-8166
> URL: https://issues.apache.org/jira/browse/SOLR-8166
> Project: Solr
> Issue Type: Improvement
> Components: contrib - Solr Cell (Tika extraction)
> Affects Versions: 5.3
> Reporter: Andriy Binetsky
>
> Actually there is no possibility to hand over some additional configuration
> by document extracting with ExtractingRequestHandler/ExtractingDocumentLoader.
> For example I need to put org.apache.tika.parser.pdf.PDFParserConfig with
> "extractInlineImages" set to true in ParseContext to trigger extraction/OCR
> recognizing of embedded images from pdf.
> It would be nice to have possibility to configure created ParseContext due
> xml-config file like TikaConfig does.
> I would suggest to have following:
> solrconfig.xml:
> <requestHandler name="/update/extract"
> class="org.apache.solr.handler.extraction.ExtractingRequestHandler">
> <str name="parseContext.config">parseContext.config</str>
> </requestHandler>
> parseContext.config:
> <entries>
> <entry class="org.apache.tika.parser.pdf.PDFParserConfig"
> value="org.apache.tika.parser.pdf.PDFParserConfig">
> <property name="extractInlineImages" value="true"/>
> </entry>
> </entries>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
