[
https://issues.apache.org/jira/browse/LUCENE-6276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14980894#comment-14980894
]
Paul Elschot commented on LUCENE-6276:
--------------------------------------
I basically agree to all of these.
bq. ... move the utility methods to compute costs of phrases from
TwoPhaseIterator into PhraseWeight/SpanNearQuery. I don't like leaking
implementation details of specific TwoPhaseIterators into TwoPhaseIterator.
and make them (package) private I assume? The only disadvantage of that is that
some duplication of these methods is needed in the spans package.
The easiest way to avoid such duplication would be when Spans move from
o.a.l.search.spans to o.a.l.search.
Iirc there was some talk of that not so long ago (Alan's plans for spans iirc),
so how about waiting for that, possibly at a separate issue?
It will take a while (at least a week) before I can continue with this. Please
feel free to take it on.
> Add matchCost() api to TwoPhaseDocIdSetIterator
> -----------------------------------------------
>
> Key: LUCENE-6276
> URL: https://issues.apache.org/jira/browse/LUCENE-6276
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Robert Muir
> Attachments: LUCENE-6276-ExactPhraseOnly.patch,
> LUCENE-6276-NoSpans.patch, LUCENE-6276-NoSpans2.patch, LUCENE-6276.patch,
> LUCENE-6276.patch, LUCENE-6276.patch, LUCENE-6276.patch, LUCENE-6276.patch
>
>
> We could add a method like TwoPhaseDISI.matchCost() defined as something like
> estimate of nanoseconds or similar.
> ConjunctionScorer could use this method to sort its 'twoPhaseIterators' array
> so that cheaper ones are called first. Today it has no idea if one scorer is
> a simple phrase scorer on a short field vs another that might do some geo
> calculation or more expensive stuff.
> PhraseScorers could implement this based on index statistics (e.g.
> totalTermFreq/maxDoc)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
