[
https://issues.apache.org/jira/browse/SOLR-6406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yonik Seeley updated SOLR-6406:
-------------------------------
Attachment: SOLR-6406.patch
Here's another patch (currently untested, but I'm going to start looping the
chaos tests... they seemed to be good at hitting this).
I added this comment to explain why I think we were hanging:
// NOTE: if the executor is shut down, runners may never become empty
(a scheduled task may never be run,
// which means it would never remove itself from the runners list.
This is why we don't wait forever
// and periodically check if the scheduler is shutting down.
So instead of waiting forever now, we periodically exit the wait and check if
the scheduler is still running.
I changed scheduler.isTerminated() to scheduler.isShutdown()... the latter
should be true when the executor is starting to try and shut down. I think the
former is only true when it actually succeeds.
I also refactored the "add another runner" logic out to addRunner()
> ConcurrentUpdateSolrServer hang in blockUntilFinished.
> ------------------------------------------------------
>
> Key: SOLR-6406
> URL: https://issues.apache.org/jira/browse/SOLR-6406
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Fix For: 5.0, Trunk
>
> Attachments: CPU Sampling.png, SOLR-6406.patch, SOLR-6406.patch,
> SOLR-6406.patch
>
>
> Not sure what is causing this, but SOLR-6136 may have taken us a step back
> here. I see this problem occasionally pop up in ChaosMonkeyNothingIsSafeTest
> now - test fails because of a thread leak, thread leak is due to a
> ConcurrentUpdateSolrServer hang in blockUntilFinished. Only started popping
> up recently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
