[ 
https://issues.apache.org/jira/browse/LUCENE-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Woodward updated LUCENE-6884:
----------------------------------
    Attachment: LUCENE-6884.patch

Patch, mostly just removing now-redundant try-catch blocks in tests.  This also 
removes IOExceptions from Tokenizer.setReader()

The only place that was actually throwing an IOException inside setReader was 
AbstractSpatialPrefixTreeFieldType, which I've changed to wrap as a 
RuntimeException.  It's apparently only used for the Solr analysis UI, so I 
think this should be fine, but it would be good if [~dsmiley] could 
double-check that.

> Analyzer.tokenStream() shouldn't throw IOException
> --------------------------------------------------
>
>                 Key: LUCENE-6884
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6884
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-6884.patch
>
>
> I'm guessing that in the past, calling Analyzer.tokenStream() would call 
> TokenStream.reset() somewhere downstream, meaning that we had to deal with 
> IOExceptions.  However, tokenstreams are created entirely lazily now, so this 
> is unnecessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to