[
https://issues.apache.org/jira/browse/SOLR-8223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14989925#comment-14989925
]
Mike Drob commented on SOLR-8223:
---------------------------------
[~cpoerschke] - do you think this is good to commit, or are there other changes
you think it should have? I tried to figure out what kind of meaningful tests I
could add, but couldn't come up with anything that was non-trivial and useful.
> Take care not to accidentally swallow OOMErrors
> -----------------------------------------------
>
> Key: SOLR-8223
> URL: https://issues.apache.org/jira/browse/SOLR-8223
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.10.3
> Reporter: Mike Drob
> Fix For: Trunk
>
> Attachments: SOLR-8223.patch
>
>
> This was first noticed with 4.10.3, but it looks like it still applies to
> trunk. There are a few places in the code where we catch {{Throwable}} and
> then don't check for OOM or rethrow it. This behaviour means that OOM kill
> scripts won't run, and the JVM can get into an undesirable state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
