[
https://issues.apache.org/jira/browse/SOLR-8249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994561#comment-14994561
]
Hoss Man commented on SOLR-8249:
--------------------------------
Ok ... beasting both of those seeds 100 times each + 100 random seeds has
passed for me.
But looking at the actual patch i'm really not a fan of this approach -- a
blanket "sleep 5 seconds" seems like a really poor solution to the problem.
If there is no way to "watch" the overseer stats then i think a spin loop with
an X second timeout would be a far better solution then a single long sleep...
{code}
// psuedo-code
checkForLeaderStatMaxWaitTime = getCurrentTIme() + X;
while (getCurrentTIme() < checkForLeaderStatMaxWaitTime) {
if (0 < overseer.getStats().getSuccessCount(OverseerAction.LEADER.toLower()))
{
break;
}
sleep(Y); // where Y is much less then X
}
assertEquals(1,
(overseer.getStats().getSuccessCount(OverseerAction.LEADER.toLower())));
{code}
> OverseerTest failures
> ---------------------
>
> Key: SOLR-8249
> URL: https://issues.apache.org/jira/browse/SOLR-8249
> Project: Solr
> Issue Type: Bug
> Reporter: Noble Paul
> Attachments: SOLR-8249.patch
>
>
> http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Windows/5377/
> This is related to SOLR-7989 . [~ichattopadhyaya] we need to fix the testcase
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
