[jira] [Commented] (SOLR-8253) AbstractDistribZkTestBase can fail to shutdown its ZkServer

[Alan Woodward (JIRA)]

    [ 
https://issues.apache.org/jira/browse/SOLR-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996296#comment-14996296
 ] 

Alan Woodward commented on SOLR-8253:
-------------------------------------

See http://jenkins.thetaphi.de/job/Lucene-Solr-5.x-Linux/14548/ for an example.

Patch is trivial enough:
{code}
diff --git 
a/solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java
 
b/solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java
index 300f628..84a16ff 100644
--- 
a/solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java
+++ 
b/solr/test-framework/src/java/org/apache/solr/cloud/AbstractDistribZkTestBase.java
@@ -268,8 +268,12 @@ public abstract class AbstractDistribZkTestBase extends 
BaseDistributedSearchTes
     
System.clearProperty(MockDirectoryFactory.SOLR_TESTS_ALLOW_READING_FILES_STILL_OPEN_FOR_WRITE);

     resetExceptionIgnores();
-    super.distribTearDown();
-    zkServer.shutdown();
+    try {
+      super.distribTearDown();
+    }
+    finally {
+      zkServer.shutdown();
+    }
   }

   protected void printLayout() throws Exception {
{code}

> AbstractDistribZkTestBase can fail to shutdown its ZkServer
> -----------------------------------------------------------
>
>                 Key: SOLR-8253
>                 URL: https://issues.apache.org/jira/browse/SOLR-8253
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Alan Woodward
>
> If there's an error shutting down the jetty servers, then zkServer.shutdown() 
> won't get called.  This ends up hiding actual errors from test failures with 
> thread-leak messages.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org