SOLR-2393 Hopefully I cut and pasted properly.
On Fri, Feb 25, 2011 at 7:14 AM, Ryan McKinley <[email protected]> wrote: > Ya, I suppose the PhoneticFilterFactory could check > "DoubleMetaphone".equals( encoder ) and then create the specialized > Filter. > > I don't feel strongly, but we could have: > EncoderFilter -- just uses 'encode()' > DoubleMetaphoneFilter - uses special double metaphone stuff > > EncoderFilterFactory -- always uses EncoderFilter, and is not > semantically bound to 'phonetic' > PhoneticFilterFactory -- picks the best phonetic filter impl (encoder > or double metaphone) > > then deprecate: > PhoneticFilter > DoubleMetaphoneFilterFactory > > Does that make sense? If so, lets make a JIRA issue for it > > ryan > > > On Fri, Feb 25, 2011 at 4:43 AM, Jan Høydahl <[email protected]> wrote: >> Technically it would be possible for the PhoneticFilterFactory to return a >> DoubleMetaphoneFilter for that specific case. Otherwise it would be better >> to just remove support for DoubleMetaphone from the PhoneticFilterFactory >> and refer to the specialized factory? >> >> -- >> Jan Høydahl, search solution architect >> Cominvent AS - www.cominvent.com >> >> On 25. feb. 2011, at 10.07, Jan Høydahl wrote: >> >>> Then it's funny that only the PhoneticFilter is mentioned on the WIKI while >>> the DoubleMetaphone is not? >>> >>> What would be the correct way to resolve this mismatch aside from fixing >>> the documentation? >>> >>> -- >>> Jan Høydahl, search solution architect >>> Cominvent AS - www.cominvent.com >>> >>> On 24. feb. 2011, at 18.10, Ryan McKinley wrote: >>> >>>>> >>>>> Is this difference on purpose? >>>> >>>> If I were to do it again... 'PhoneticFilter' should really be >>>> EncoderFilter since it just uses the encoder API to generate tokens. >>>> There is nothing specific to 'phonetic' -- In fact, when I implement >>>> KStem, I use the PhoneticFilter?! >>>> https://issues.apache.org/jira/browse/SOLR-379?focusedCommentId=12934562&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-12934562 >>>> >>>> DoubleMetaphone however uses the DoubleMetaphone API and generatates >>>> special tokens based on that. >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: [email protected] >>>> For additional commands, e-mail: [email protected] >>>> >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: [email protected] >>> For additional commands, e-mail: [email protected] >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [email protected] >> For additional commands, e-mail: [email protected] >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
