[ 
https://issues.apache.org/jira/browse/SOLR-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998923#comment-14998923
 ] 

Hoss Man commented on SOLR-8057:
--------------------------------

bq. If there are no concerns/objections to Task #3 by the time I get to that 
point, and if i haven't changed my mind that it's a good idea, I'll move 
forward with that as well

Thinking about it more -- there is very little downside in first switching to 
BM25 as a default on trunk, and only _after_ that is done using a new issue to 
discuss/change the default to SchemaSimilarityFactory -- at which point, all 
existing tests should just pass.

This also lets us move forward with a better (BM25) default behavior in the 
common case, even if there are in fact bugs with using a SolrCoreAware 
SimFactory as the default (which is what it looked like in my early patches)

So i'll do "Task #3" as a new independent jira, and make a subtask for my new 
"Task 2.5: Make BM25SimFactory the implicit default in trunk"

> Change default Sim to BM25 (w/backcompat config handling)
> ---------------------------------------------------------
>
>                 Key: SOLR-8057
>                 URL: https://issues.apache.org/jira/browse/SOLR-8057
>             Project: Solr
>          Issue Type: Task
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Blocker
>             Fix For: Trunk
>
>         Attachments: SOLR-8057.patch, SOLR-8057.patch
>
>
> LUCENE-6789 changed the default similarity for IndexSearcher to BM25 and 
> renamed "DefaultSimilarity" to "ClassicSimilarity"
> Solr needs to be updated accordingly:
> * a "ClassicSimilarityFactory" should exist w/expected behavior/javadocs
> * default behavior (in 6.0) when no similarity is specified in configs should 
> (ultimately) use BM25 depending on luceneMatchVersion
> ** either by assuming BM25SimilarityFactory or by changing the internal 
> behavior of DefaultSimilarityFactory
> * comments in sample configs need updated to reflect new default behavior
> * ref guide needs updated anywhere it mentions/implies that a particular 
> similarity is used (or implies TF-IDF is used by default)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to