[
https://issues.apache.org/jira/browse/SOLR-8288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15004799#comment-15004799
]
Mike Drob commented on SOLR-8288:
---------------------------------
bq. + &&
!stdNode.getNodeProps().getCoreUrl().equals(leaderProps.getCoreUrl())) { // we
do not want to put ourself into LIR
If we are comparing URLs, then would it make sense to check against the
[replicaURL|https://github.com/apache/lucene-solr/blob/eab11f7fe242710216786db70814a0f492342b38/solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java#L824]
that we saw the error on?
{{replicaUrl.equals(leaderProps.getCoreUrl())}} instead?
> DistributedUpdateProcessor#doFinish should explicitly check and ensure it
> does not try to put itself into LIR.
> --------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8288
> URL: https://issues.apache.org/jira/browse/SOLR-8288
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: 5.4, Trunk
>
> Attachments: SOLR-8288.patch
>
>
> We have to be careful about this because currently, something like a commit
> is sent over http even to the local node and if that fails for some reason,
> the leader might try and LIR itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
