Christine Poerschke created SOLR-8298:
-----------------------------------------
Summary: small preferLocalShards implementation refactor
Key: SOLR-8298
URL: https://issues.apache.org/jira/browse/SOLR-8298
Project: Solr
Issue Type: Wish
Reporter: Christine Poerschke
Assignee: Christine Poerschke
Priority: Minor
Towards rebasing the SOLR-6730 patch after SOLR-6832 and other changes -
proposed patch against trunk to follow.
existing calling chain:
* {{ResponseBuilder.addRequest(... ShardRequest sreq)}} does {{sreq.rb =
this;}} so that later on {{HttpShardHandler.submit(ShardRequest sreq ...)}} can
do {{sreq.rb.req.getOriginalParams().getBool}} for
{{CommonParams.PREFER_LOCAL_SHARDS}}
proposed alternative calling chain:
* {{HttpShardHandler.prepDistributed(ResponseBuilder rb)}} sets
{{rb.preferredHostAddress}} and {{SearchHandler}} calls
{{ShardHandler.submit(ShardRequest sreq ... rb.preferredHostAddress)}}
structural changes:
* {{ShardRequest.rb}} member removed in favour of a new
{{ResponseBuilder.preferredHostAddress}} member.
* {{String preferredHostAddress}} argument added to the abstract
{{ShardHandler.submit}} method (and to two derived (test) classes' submit
methods also).
* {code}public void submit(ShardRequest sreq, String shard,
ModifiableSolrParams params) { submit(sreq, shard, params, null); } {code}
added to avoid having to change {{ShardHandler.submit}} callers which don't
have a concept of preferring a local shard e.g. for PeerSync requests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
