[ 
https://issues.apache.org/jira/browse/SOLR-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009122#comment-15009122
 ] 

Hoss Man commented on SOLR-8290:
--------------------------------

Some historical context for when/why this param was added in SOLR-2348...

bq. with that in mind, i think for now the most straight forward thing to do is 
to add a "checkFieldCacheSource(QParser)" method to SchemaField that would be 
cut/paste of checkSortability (with the error message wording changed) and make 
all of the (applicable) FieldType.getValueSource methods call it. In the 
future, it could evolve differently then checkSortability – either removing the 
"!multivalued" assertion completley, or introspecting the Qparser context in 
some way to determine that neccessary info has been provided to know how to use 
the (hypothetical) multivalued FieldCache (hard t ospeculate at this point)

...since it evidently hasn't proved useful since then, no objections to 
removing now (although i'm not sure what downside there was to leaving it in 
either)

> remove SchemaField.checkFieldCacheSource's unused QParser argument
> ------------------------------------------------------------------
>
>                 Key: SOLR-8290
>                 URL: https://issues.apache.org/jira/browse/SOLR-8290
>             Project: Solr
>          Issue Type: Wish
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-8290.patch
>
>
> From what I could see with a little looking around the argument was added in 
> 2011 but not used then or since.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to