[ 
https://issues.apache.org/jira/browse/SOLR-8326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anshum Gupta updated SOLR-8326:
-------------------------------
    Attachment: SOLR-8326.patch

Thanks for the patch Noble. I've changed log levels and reduced visibility of 
methods where I could. I've also made a few things final in this patch where I 
thought it made sense.
The rest looks good to me.

I tested this out with:
* Start a 2 node cluster with external zk and security.json in place
* Try creating a collection and adding a replica - positive
* Add collection-admin-edit rule and make sure that credentials are required - 
positive
* Restart one of the nodes and see there are no errors - positive
* Add read user and permission, then create a collection - positive
* Add a replica on the new collection - positive
* Restart one of the nodes and make sure there are no errors and the replicas 
are healthy once the node is up - positive

It'd be good to add a test here so that we don't regress. It could be a PKI 
test or a Chaos monkey test perhaps, but then we'll need to figure a way to get 
Chaos monkey to work with MiniSolrCloudCluster so we could upload the security 
conf etc. 
For now, I think we should commit this as I'm not sure how long would the test 
itself take considering we're close to cutting the 5.4 branch and this is a 
blocker.

> PKIAuthenticationPlugin doesn't report any errors in case of stale or wrong 
> keys and returns garbage
> ----------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8326
>                 URL: https://issues.apache.org/jira/browse/SOLR-8326
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.3, 5.3.1
>            Reporter: Anshum Gupta
>            Assignee: Noble Paul
>            Priority: Blocker
>             Fix For: 5.4
>
>         Attachments: SOLR-8326.patch, SOLR-8326.patch, SOLR-8326.patch
>
>
> This was reported on the mailing list:
> https://www.mail-archive.com/solr-user@lucene.apache.org/msg115921.html
> I tested it out as follows to confirm that adding a 'read' rule causes 
> replication to break. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to