[ 
https://issues.apache.org/jira/browse/LUCENE-5868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15031595#comment-15031595
 ] 

Martijn van Groningen commented on LUCENE-5868:
-----------------------------------------------

+1 this looks good. One small thing, maybe rename the parameter name in the 
protected `createJoinQuery(...)` method from `termsWithScoreCollector` to just 
`collector`?

> JoinUtil support for NUMERIC docValues fields 
> ----------------------------------------------
>
>                 Key: LUCENE-5868
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5868
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Mikhail Khludnev
>            Assignee: Mikhail Khludnev
>            Priority: Minor
>             Fix For: 5.5
>
>         Attachments: LUCENE-5868-lambdarefactoring.patch, 
> LUCENE-5868-lambdarefactoring.patch, LUCENE-5868.patch, LUCENE-5868.patch, 
> LUCENE-5868.patch, qtj.diff
>
>
> while polishing SOLR-6234 I found that JoinUtil can't join int dv fields at 
> least. 
> I plan to provide test/patch. It might be important, because Solr's join can 
> do that. Please vote if you care! 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to