[ 
https://issues.apache.org/jira/browse/SOLR-8354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15032759#comment-15032759
 ] 

Mike Drob commented on SOLR-8354:
---------------------------------

Looks like this was originally added by [~markrmil...@gmail.com] - 
https://github.com/apache/lucene-solr/commit/9cb587e216283275ddcd8161a6306daf7b924cfc
 with the comment and the logic coming in at the same time. [~shalinmangar] 
later changed the 600 to 60.

Do you guys know what the intent here is? Happy to adjust the comment and 
logging instead of the logic, depending on which one can be considered the 
source of truth.

> RecoveryStrategy retry timing is innaccurate
> --------------------------------------------
>
>                 Key: SOLR-8354
>                 URL: https://issues.apache.org/jira/browse/SOLR-8354
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Mike Drob
>         Attachments: SOLR-8354.patch
>
>
> At the end of {{RecoveryStrategy::doRecovery}} there is a retry segment, with 
> a comment that suggests the code will {{// start at 1 sec and work up to a 
> min}}. The code will actually start at 10 seconds, and work up to 5 minutes. 
> Additionally, the log statement incorrectly reports how long the next wait 
> will be. Either the comment and log should be corrected or the logic adjusted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to