[
https://issues.apache.org/jira/browse/LUCENE-6918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15041379#comment-15041379
]
Ryan Ernst commented on LUCENE-6918:
------------------------------------
+1, looks good.
For the changes entry, I think you mean to remove the "not" from "is not only
called"?
> LRUQueryCache.onDocIdSetEviction should not be called when nothing is evicted
> -----------------------------------------------------------------------------
>
> Key: LUCENE-6918
> URL: https://issues.apache.org/jira/browse/LUCENE-6918
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 5.5
>
> Attachments: LUCENE-6918.patch
>
>
> This method is confusing because it states it will be called "when one or
> more DocIdSets are removed from this cache" but may actually be called with
> zero docidsets when evicting a per-segment cache that did not contain any
> entries.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
