[
https://issues.apache.org/jira/browse/LUCENE-2939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002917#comment-13002917
]
Mark Miller commented on LUCENE-2939:
-------------------------------------
bq. The patch needs more than a simple back port. The patch needs to be fixed.
And that is simple too if you follow the above comments.
You should pop the offset calculation into the if statement -
I'm not convinced it's a problem in this situation (especially for someone
wanting to try a patch), because this works one document at a time.
Its also simple not to break the api as I mention above.
I have done all of these things in my own work earlier (and added a test for
the new filter) - took about 2 minutes.
Eventually I will post another trunk patch.
Doing a solid review and back port of this patch would not take long - it's
fairly simple. I won't likely get to it for 3.X for a while though.
> Highlighter should try and use maxDocCharsToAnalyze in
> WeightedSpanTermExtractor when adding a new field to MemoryIndex as well as
> when using CachingTokenStream
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2939
> URL: https://issues.apache.org/jira/browse/LUCENE-2939
> Project: Lucene - Java
> Issue Type: Bug
> Components: contrib/highlighter
> Reporter: Mark Miller
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 3.1.1, 3.2, 4.0
>
> Attachments: LUCENE-2939.patch, LUCENE-2939.patch, LUCENE-2939.patch
>
>
> huge documents can be drastically slower than need be because the entire
> field is added to the memory index
> this cost can be greatly reduced in many cases if we try and respect
> maxDocCharsToAnalyze
> things can be improved even further by respecting this setting with
> CachingTokenStream
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
