[
https://issues.apache.org/jira/browse/SOLR-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-8419:
-------------------------------
Attachment: SOLR_8419.patch
The attach patch:
* Fixes the invalid/confusing response when there's a distributed single-pass
situation.
* Removed {{uniqueKeyFieldName}} as a key in the TV response NamedList. Okay I
didn't have to do this but this seemed totally out of place.
HighlightComponent & DebugComponent don't do this.
* Added test that fails without these changes -- the distrib.singlePass case.
The changes also then allows for an eventual refactoring of common code in
finishStage (the loop filling {{arr}}). This is the part affected by a
distrib.singlePass bug in 3 search components. I won't do that refactoring
here though; I'll do it in BNGS-8059.
Assuming tests pass I'll commit this in a couple days.
> TermVectorComponent distributed-search issues
> ---------------------------------------------
>
> Key: SOLR-8419
> URL: https://issues.apache.org/jira/browse/SOLR-8419
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Reporter: David Smiley
> Assignee: David Smiley
> Fix For: 5.5
>
> Attachments: SOLR_8419.patch
>
>
> TermVectorComponent supports distributed-search since SOLR-3229 added it.
> Unlike most other components, this one tries to support schemas without a
> UniqueKey. However it's logic for attempting to do this was made faulty with
> the introduction of distrib.singlePass, and furthermore this part wasn't
> tested any way. In this issue I want to remove support for schemas lacking a
> UniqueKey with this component (only for distributed-search).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
