[
https://issues.apache.org/jira/browse/SOLR-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066099#comment-15066099
]
Mikhail Khludnev commented on SOLR-8395:
----------------------------------------
I skimmed through [^SOLR-8395.patch]
* {{ScoreJoinQParserPlugin.OtherCoreJoinQuery.rewrite(IndexReader)}}
ignores {{numericType}}, thus pls extract the calling one of
{{JoinUtil.createJoinQuery()} into a method in SameCoreJoinQuery. Or even
introduce a strategy in ScoreJoinQParserPlugin dispatching between these two
factory methods.
* if it happened, would you mind to add a test coverage into TestCrossCoreJoin?
I'm asking because joining cross cores by numbers is an often demand.
* Also, you added a perfect assert for matching numeric types, can you check it
with negative assertions with assertQEx() ?
> query-time join (with scoring) for single value numeric fields
> --------------------------------------------------------------
>
> Key: SOLR-8395
> URL: https://issues.apache.org/jira/browse/SOLR-8395
> Project: Solr
> Issue Type: Improvement
> Components: search
> Reporter: Mikhail Khludnev
> Priority: Minor
> Labels: easytest, features, newbie, starter
> Fix For: 5.5
>
> Attachments: SOLR-8395.patch, SOLR-8395.patch, SOLR-8395.patch
>
>
> since LUCENE-5868 we have an opportunity to improve SOLR-6234 to make it join
> int and long fields. I suppose it's worth to add "simple" test in Solr
> NoScore suite.
> * Alongside with that we can set _multipleValues_ parameters giving
> _fromField_ cardinality declared in schema;
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
