[
https://issues.apache.org/jira/browse/SOLR-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066781#comment-15066781
]
Mark Miller commented on SOLR-7339:
-----------------------------------
So that fail seems pretty odd.
We can only hit that fail if: !(client instanceof HttpSolrClient)
And client can only be HttpSolrClient or EmbeddedSolrServer. It should not be
EmbeddedSolrServer, because we make a Jetty for this test and presumably a
Jetty is involved in this connection reset business. So we really expect that
client to be an HttpSolrClient don't we?
So how do we get to this fail message below unless we are using
EmbeddedSolrServer?
{code}
client.add(doc);
if(client instanceof HttpSolrClient) { //XXX concurrent client reports
exceptions differently
fail("Operation should throw an exception!");
} else {
client.commit(); //just to be sure the client has sent the doc
ErrorTrackingConcurrentUpdateSolrClient concurrentClient =
(ErrorTrackingConcurrentUpdateSolrClient) client;
assertNotNull("ConcurrentUpdateSolrClient did not report an error",
concurrentClient.lastError);
assertTrue("ConcurrentUpdateSolrClient did not report correct error: "
+ concurrentClient.lastError.getMessage(),
concurrentClient.lastError.getMessage().contains("Conflict"));
}
{code}
> Upgrade Jetty from 9.2 to 9.3
> -----------------------------
>
> Key: SOLR-7339
> URL: https://issues.apache.org/jira/browse/SOLR-7339
> Project: Solr
> Issue Type: Improvement
> Reporter: Gregg Donovan
> Assignee: Shalin Shekhar Mangar
> Fix For: Trunk
>
> Attachments: SOLR-7339.patch, SOLR-7339.patch,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty92.pcapng,
> SolrExampleStreamingBinaryTest.testUpdateField-jetty93.pcapng
>
>
> Jetty 9.3 offers support for HTTP/2. Interest in HTTP/2 or its predecessor
> SPDY was shown in [SOLR-6699|https://issues.apache.org/jira/browse/SOLR-6699]
> and [on the mailing list|http://markmail.org/message/jyhcmwexn65gbdsx].
> Among the HTTP/2 benefits over HTTP/1.1 relevant to Solr are:
> * multiplexing requests over a single TCP connection ("streams")
> * canceling a single request without closing the TCP connection
> * removing [head-of-line
> blocking|https://http2.github.io/faq/#why-is-http2-multiplexed]
> * header compression
> Caveats:
> * Jetty 9.3 is at M2, not released.
> * Full Solr support for HTTP/2 would require more work than just upgrading
> Jetty. The server configuration would need to change and a new HTTP client
> ([Jetty's own
> client|https://github.com/eclipse/jetty.project/tree/master/jetty-http2],
> [Square's OkHttp|http://square.github.io/okhttp/],
> [etc.|https://github.com/http2/http2-spec/wiki/Implementations]) would need
> to be selected and wired up. Perhaps this is worthy of a branch?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
