[
https://issues.apache.org/jira/browse/SOLR-8451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15069755#comment-15069755
]
Mark Miller commented on SOLR-8451:
-----------------------------------
bq. whenever there's any chance that the response has not been fully read
No documentation I can find says that.
If you make a little test, you will see that method.abort prevents connection
reuse. When Solr throws expected errors for updates, we don't want to poison
the connection, we want it to go back to the pool. If we actually had to read
the full stream, it would be better to just do that. But again, testing and any
documentation I can find shows that we just have to close the stream - we don't
have to read it all. And connections are released happily back to the pool for
reuse.
There is no need for abort here. Nor was it even having an affect when it was
called after the content stream close (which it always was).
> We should not call method.abort in HttpSolrClient.
> --------------------------------------------------
>
> Key: SOLR-8451
> URL: https://issues.apache.org/jira/browse/SOLR-8451
> Project: Solr
> Issue Type: Bug
> Reporter: Mark Miller
> Assignee: Mark Miller
> Attachments: SOLR-8451.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
