[
https://issues.apache.org/jira/browse/SOLR-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15070022#comment-15070022
]
David Smiley commented on SOLR-8460:
------------------------------------
Thanks for your review Uwe! It's good to get more eyes on each others work.
Looks like our first comments were written simultaneously without the benefit
of each of us seeing what the other were about to say.
bq. Thats a bug in your TokenStream! getAttribute is only available for
TokenStream consumers that don't want to add attributes they don't need.
Producer code must always use addAttribute().
I wrote an Attribute implementation in such a way that it didn't _require_ some
other attribute, but if it was present then it affected the functionality of
the Attribute. So to know if it's present or not, I called getAttribute.
Do you think the patch is fine as is to be committed or do you have
concerns/feedback?
> /analysis/field doesn't always handle custom attributes correctly
> -----------------------------------------------------------------
>
> Key: SOLR-8460
> URL: https://issues.apache.org/jira/browse/SOLR-8460
> Project: Solr
> Issue Type: Bug
> Components: Schema and Analysis
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
> Fix For: 5.5
>
> Attachments: SOLR_8460.patch
>
>
> I've got some custom analysis Attribute implementations in my analysis chain
> with some other custom analysis components. I found that Solr's Analysis
> utility screen, powered by /field/analysis (FieldAnalysisRequestHandler
> subclassing AnalysisRequestHandlerBase) gave me exceptions for two reasons,
> both having to do with AnalysisRequestHandlerBase.ListBasedTokenStream:
> * Custom implementations of standard Attributes (e.g. FlagsAttribute) would
> trigger an exception.
> * Calling getAttribute (instead of addAttribute) in a TokenFilter constructor
> wouldn't find an attribute added by the input TokenStream.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
