[
https://issues.apache.org/jira/browse/SOLR-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15073961#comment-15073961
]
Cao Manh Dat commented on SOLR-8458:
------------------------------------
{quote}
What's the purpose of ClientTupleStream? It appears it's only used in the tests
and doesn't add any value as a Stream object.
{quote}
I create a class to simplify the code in test class. Currently, we dont have
any TupleStream which support passing SolrClient and SolrParams. in SolrStream,
we pass in baseUrl and it always create HttpSolrClient (not CloudClient). In
CloudSolrStream, we pass in ZKAdress and it always look up for fl & sort
params...
{quote}
I don't think it'd be necessary to test that substitution on each and every
stream class because the implementation is outside of the stream classes.
{quote}
I good point. I forgot that query parameter substitution already been tested in
other class. We just wanna to show the guide here. I will write a
testSubstituteStream method which code derive from testMergeStream()
> Add Streaming Expressions tests for parameter substitution
> ----------------------------------------------------------
>
> Key: SOLR-8458
> URL: https://issues.apache.org/jira/browse/SOLR-8458
> Project: Solr
> Issue Type: Improvement
> Reporter: Joel Bernstein
> Priority: Minor
> Attachments: SOLR-8458.patch, SOLR-8458.patch
>
>
> This ticket is to add Streaming Expression tests that exercise the existing
> macro expansion feature described here:
> http://yonik.com/solr-query-parameter-substitution/
> Sample syntax below:
> {code}
> http://localhost:8983/col/stream?expr=merge(${left}, ${right},
> ...)&left=search(...)&right=search(...)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
