[ https://issues.apache.org/jira/browse/LUCENE-6965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15088298#comment-15088298 ]
Tomás Fernández Löbbe commented on LUCENE-6965: ----------------------------------------------- bq. Another alternative is to use the "rethrower" and directly throw ParseException without declaring it. Currently only in test-framework and AttributeFactory classes (to handle invokeExact rethrowing, the one in AttributeFactory is more compact...). OK, that would remove the need of the ParseRuntimeException, right? > Expression's JavascriptCompiler to throw ParseExceptions with bad function > names or arity > ----------------------------------------------------------------------------------------- > > Key: LUCENE-6965 > URL: https://issues.apache.org/jira/browse/LUCENE-6965 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Tomás Fernández Löbbe > Attachments: LUCENE-6965.patch, LUCENE-6965.patch > > > Currently JavascriptCompiler will throw IllegalArgumentException for bad > function names (or functions that don't exist) and for bad arity. I can see > why this was done this way, but I believe ParseException would also be > correct and it would be better since that's the exception clients will be > prepared to receive. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org