[ 
https://issues.apache.org/jira/browse/SOLR-8561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105023#comment-15105023
 ] 

Varun Thacker commented on SOLR-8561:
-------------------------------------

I noticed something while testing out manually.

When you run {{solr start -e cloud -noprompt}} here are the following outputs 
on solr 5.3.0 and lucene_solr_5_4 branch 

1. solr 5.3.0
{code}
~/solr-5.3.0 $ ls example/cloud/node1/
logs    solr
~/solr-5.3.0 $ ls example/cloud/node1/solr/
gettingstarted_shard1_replica2  gettingstarted_shard2_replica2  solr.xml        
                zoo.cfg                         zoo_data
{code}

lucene_solr_5_4 with the patch

{code}
~/apache-work/lucene_solr_5_4/solr $ ls  example/cloud/node1/
logs            solr            solrzoo_data
~/apache-work/lucene_solr_5_4/solr $ ls  example/cloud/node1/solr
gettingstarted_shard1_replica1  gettingstarted_shard2_replica1  solr.xml        
                zoo.cfg
{code}

On the 5_4 branch the directory seems to be concatenated i.e solrzoo_data 
instead of solr/zoo_data . It's unrelated to the patch but this tripped me

So here were the steps I used to try out the patch manually
- Started Solr 5.3.0 : ./bin/solr start -e cloud -noprompt
- Node /collections/gettingstarted/leaders/shard1 exists 
- Stopped Solr
- Ran Solr from the 5.4 branch with the patch applied and also copied over 
example/cloud directory from 5.3 ( with some manual changes because of the 
directory structure change mentioned above)
- The gettingstarted collection came up healthy and a node 
/collections/gettingstarted/leaders/shard1/leader exists instead.

So +1 to the patch. I'll file a Jira for the directory structure change in the 
cloud example 

> Add fallback to ZkController.getLeaderProps for a mixed 5.4-pre-5.4 
> deployments
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-8561
>                 URL: https://issues.apache.org/jira/browse/SOLR-8561
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: SOLR-8561.patch, SOLR-8561.patch
>
>
> See last comments in SOLR-7844. The latter changed the structure of the 
> leader path in ZK such that upgrading from pre-5.4 to 5.4 is impossible, 
> unless all nodes are taken down. This issue adds a fallback logic to look for 
> the leader properties on the old ZK node, as discussed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to