[
https://issues.apache.org/jira/browse/SOLR-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15109324#comment-15109324
]
Steve Rowe commented on SOLR-8567:
----------------------------------
I looked at the patch on this issue, and I don't think adding the queryparser
module's test .class files to the test phase classpath via a testResource is
the way to go.
Maven has a standard mechanism for this, which is used elsewhere in the build
(e.g. the dih-extras module has a test dependency on the dih module's tests):
maven-jar-plugin:test-jar will generate a jar of test classes on the producer
module side, and then the consumer module depends on this jar via a test-scope
dependency of type {{test-jar}}.
I'll work up a patch.
> SOLR-839 broke the Maven build (trunk, 5.5)
> -------------------------------------------
>
> Key: SOLR-8567
> URL: https://issues.apache.org/jira/browse/SOLR-8567
> Project: Solr
> Issue Type: Bug
> Components: Build
> Affects Versions: 5.5, Trunk
> Reporter: Daniel Collins
> Assignee: Christine Poerschke
> Priority: Minor
> Attachments: SOLR-8567.patch
>
>
> SOLR-839 adds a new code dependency between the Solr test code and the Lucene
> test code. ant handles this with some updates to the common-build.xml
> (included in SOLR-839) but the maven build mechanism needs updates to the
> pom.xml.template with an equivalent change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
