[ https://issues.apache.org/jira/browse/SOLR-8560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15111310#comment-15111310 ]
Anshum Gupta commented on SOLR-8560: ------------------------------------ Thanks Shai. Looks good overall other than the following: * Why reorder imports in AbstractFullDistribTestBase? The patched file has imports above the license header * CollectionsHandler.addStatusToResponse() does not use requestId. We should remove it from there * DistribDocExpirationUpdateProcessorTest has no real changes but just formatting. Also, it's completely unrelated to the issue. > Add RequestStatusState enum > --------------------------- > > Key: SOLR-8560 > URL: https://issues.apache.org/jira/browse/SOLR-8560 > Project: Solr > Issue Type: Improvement > Components: clients - java > Reporter: Shai Erera > Assignee: Shai Erera > Priority: Minor > Fix For: 5.5, Trunk > > Attachments: SOLR-8560.patch > > > The REQUESTSTATUS API returns a "state" that is currently a String. This > issue adds a {{RequestStatusState}} enum with the currently returned > constants, for easier integration by clients. For backwards compatibility it > parses the returned state in a lowercase form, as well resolve "notfound" to > {{NOT_FOUND}}. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org