[
https://issues.apache.org/jira/browse/LUCENE-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112468#comment-15112468
]
Michael McCandless commented on LUCENE-6930:
--------------------------------------------
Hmm I'm seeing this test failure with this patch:
{noformat}
[junit4:pickseed] Seed property 'tests.seed' already defined: 3B2C0D9EBF6EC99D
[junit4] <JUnit4> says hello! Master seed: 3B2C0D9EBF6EC99D
[junit4] Executing 1 suite with 1 JVM.
[junit4]
[junit4] Started J0 PID(30297@localhost).
[junit4] Suite: org.apache.lucene.search.TestGeoPointQuery
[junit4] 1> T4: id=7224 should not match but did
[junit4] 1> small=true query=GeoPointInBBoxQuery: field=point: Lower
Left: [85.35664315745854,-41.59146759172397] Upper Right:
[86.66116425340478,-40.74649261518726] docID=7060
[junit4] 1> lat=-40.74649160581509 lon=86.53170426878272
[junit4] 1> deleted?=false
[junit4] 2> jan 22, 2016 2:35:24 PM
com.carrotsearch.randomizedtesting.RandomizedRunner$QueueUncaughtExceptionsHandler
uncaughtException
[junit4] 2> WARNING: Uncaught exception in thread:
Thread[T4,5,TGRP-TestGeoPointQuery]
[junit4] 2> java.lang.AssertionError: some hits were wrong
[junit4] 2> at
__randomizedtesting.SeedInfo.seed([3B2C0D9EBF6EC99D]:0)
[junit4] 2> at org.junit.Assert.fail(Assert.java:93)
[junit4] 2> at
org.apache.lucene.util.BaseGeoPointTestCase$VerifyHits.test(BaseGeoPointTestCase.java:552)
[junit4] 2> at
org.apache.lucene.util.BaseGeoPointTestCase$2._run(BaseGeoPointTestCase.java:756)
[junit4] 2> at
org.apache.lucene.util.BaseGeoPointTestCase$2.run(BaseGeoPointTestCase.java:623)
[junit4] 2>
[junit4] 2> NOTE: reproduce with: ant test -Dtestcase=TestGeoPointQuery
-Dtests.method=testAllLonEqual -Dtests.seed=3B2C0D9EBF6EC99D
-Dtests.multiplier=2 -Dtests.slow=true
-Dtests.linedocsfile=/lucenedata/hudson.enwiki.random.lines.txt.fixed
-Dtests.locale=no -Dtests.timezone=Europe/Jersey -Dtests.asserts=true
-Dtests.file.encoding=UTF-8
[junit4] ERROR 2.46s | TestGeoPointQuery.testAllLonEqual <<<
[junit4] > Throwable #1: java.lang.AssertionError
[junit4] > at
org.apache.lucene.util.BaseGeoPointTestCase.verify(BaseGeoPointTestCase.java:770)
[junit4] > at
org.apache.lucene.util.BaseGeoPointTestCase.testAllLonEqual(BaseGeoPointTestCase.java:203)
[junit4] > at java.lang.Thread.run(Thread.java:745)Throwable #2:
com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught
exception in thread: Thread[id=19, name=T4, state=RUNNABLE,
group=TGRP-TestGeoPointQuery]
[junit4] > Caused by: java.lang.AssertionError: some hits were wrong
[junit4] > at
__randomizedtesting.SeedInfo.seed([3B2C0D9EBF6EC99D]:0)
[junit4] > at
org.apache.lucene.util.BaseGeoPointTestCase$VerifyHits.test(BaseGeoPointTestCase.java:552)
[junit4] > at
org.apache.lucene.util.BaseGeoPointTestCase$2._run(BaseGeoPointTestCase.java:756)
[junit4] > at
org.apache.lucene.util.BaseGeoPointTestCase$2.run(BaseGeoPointTestCase.java:623)
[junit4] 2> NOTE: test params are: codec=Asserting(Lucene60):
{id=FSTOrd50, point=PostingsFormat(name=MockRandom)},
docValues:{id=DocValuesFormat(name=Direct),
point=DocValuesFormat(name=Memory)}, sim=ClassicSimilarity, locale=no,
timezone=Europe/Jersey
[junit4] 2> NOTE: Linux 3.13.0-71-generic amd64/Oracle Corporation
1.8.0_60 (64-bit)/cpus=8,threads=1,free=417685072,total=493355008
[junit4] 2> NOTE: All tests run in this JVM: [TestGeoPointQuery]
[junit4] Completed [1/1 (1!)] in 2.87s, 1 test, 1 error <<< FAILURES!
[junit4]
[junit4]
[junit4] Tests with failures [seed: 3B2C0D9EBF6EC99D]:
[junit4] - org.apache.lucene.search.TestGeoPointQuery.testAllLonEqual
{noformat}
> Decouple GeoPointField from NumericType
> ---------------------------------------
>
> Key: LUCENE-6930
> URL: https://issues.apache.org/jira/browse/LUCENE-6930
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Nicholas Knize
> Attachments: LUCENE-6930.patch, LUCENE-6930.patch, LUCENE-6930.patch
>
>
> {{GeoPointField}} currently relies on {{NumericTokenStream}} to create prefix
> terms for a GeoPoint using the precision step defined in {{GeoPointField}}.
> At search time {{GeoPointTermsEnum}} recurses to a max precision that is
> computed by the Query parameters. This max precision is never the full
> precision, so creating and indexing the full precision terms is useless and
> wasteful (it was always a side effect of just using indexing logic from the
> Numeric type).
> Furthermore, since the numerical logic always stored high precision terms
> first, the recursion in {{GeoPointTermsEnum}} required transient memory for
> storing ranges. By moving the trie logic to its own {{GeoPointTokenStream}}
> and reversing the term order (such that lower resolution terms are first),
> the GeoPointTermsEnum can naturally traverse, enabling on-demand creation of
> PrefixTerms. This will be done in a separate issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
