[
https://issues.apache.org/jira/browse/SOLR-7968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-7968:
-------------------------------
Priority: Minor (was: Major)
Issue Type: Improvement (was: Bug)
Looks good. I tweaked your patch a little locally: I found one extra spot that
should call the getResponseDocs() method vs the direct field... and one rename
you did from "private" to "protected" was in a comment that didn't make sense
to rename... and I optimized some imports. I'll be committing shortly.
Thanks for contributing Markus!
> Allow extending QueryComponent
> ------------------------------
>
> Key: SOLR-7968
> URL: https://issues.apache.org/jira/browse/SOLR-7968
> Project: Solr
> Issue Type: Improvement
> Components: SearchComponents - other
> Affects Versions: 5.2.1
> Reporter: Markus Jelsma
> Assignee: David Smiley
> Priority: Minor
> Fix For: 5.5
>
> Attachments: SOLR-7968.patch, SOLR-7968.patch
>
>
> QueryComponent is, after all this time, still not extendable. Overriding a
> simple method is mostly impossible due to members being private or usage of
> non-public classes. Copying all code to an external class is also not going
> to work because of this. This patch finally allows overriding QueryComponent
> methods such as createMainQuery and mergeIds.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
