[ https://issues.apache.org/jira/browse/SOLR-8621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15127916#comment-15127916 ]
Shai Erera commented on SOLR-8621: ---------------------------------- [~cpoerschke] about the commit, I have few comments: * {{MergePolicyFactory}}, IMO, should belong to Solr. I don't see it being used by Lucene users, as they already construct {{IndexWriterConfig}} which takes a {{MergePolicy}} instance. The factory, again IMO, is useful in Solr-land, because Solr is configured from a file and therefore being able to construct an MP from a set of properties will be useful to Solr users. * I don't fully get the purpose of {{MergePolicyFactoryHelper}}. Did you create that abstraction so we can use it in Solr? If we move MPF to Solr, I think we can get rid of it? Its only purpose as I can tell is to create an instance of an MP, but I thought that's what the factory will do? * {{SimpleMergePolicyFactory}} is what I had in mind for the simple MPs. I wonder if we took the actual MPs class name in the properties, we wouldn't need {{TieredMPF}}, and will also simply support {{LogMP}}. What do you think? The XML element would look like: {code} <mergePolicyFactory class="solr.SimpleMergePolicyFactory"> <str name="class">solr.TieredMergePolicy</str> ... </mergePolicyFactory> {code} What do you think? * Is it OK if I make some changes to the code and push to the branch, or are you actively working on it? > solrconfig.xml: deprecate/replace <mergePolicy> with <mergePolicyFactory> > ------------------------------------------------------------------------- > > Key: SOLR-8621 > URL: https://issues.apache.org/jira/browse/SOLR-8621 > Project: Solr > Issue Type: Task > Reporter: Christine Poerschke > Assignee: Christine Poerschke > > *<mergePolicyFactory> end-user benefits:* > * Lucene's UpgradeIndexMergePolicy can be configured in Solr > * (with SOLR-5730) Lucene's SortingMergePolicy can be configured in Solr > * customisability: arbitrary merge policies including wrapping/nested merge > policies can be created and configured > *(proposed) roadmap:* > * solr 5.5 introduces <mergePolicyFactory> support > * solr 5.5(\?) deprecates (but maintains) <mergePolicy> support > * solr 6.0(\?) removes <mergePolicy> support > +work-in-progress git branch:+ > [master-solr-8621|https://github.com/apache/lucene-solr/tree/master-solr-8621] -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org