[ 
https://issues.apache.org/jira/browse/SOLR-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129422#comment-15129422
 ] 

Timothy Potter commented on SOLR-8135:
--------------------------------------

Chatting with [~hossman_luc...@fucit.org], it seems like the SolrConfigHandler 
should be able to leverage the CloseHook support in SolrCore to be able to 
detect a core is being closed and stop its attempts at refreshing config.

Moreover, as I thought about the previous comment some more, I actually think 
the true bug here is the config handler returns before the config change has 
been applied (it seems from the log anyway) ... not sure why anyone would want 
a config update request to return to them before the change has been applied 
across the cluster? Seems hard for a client app to reason about whether a 
change is fully applied or not with the way things are w/o adding arbitrary 
waits, which would just be a bandaid in the SolrCloudExampleTest.

> SolrCloudExampleTest.testLoadDocsIntoGettingStartedCollection reproducible 
> failure
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-8135
>                 URL: https://issues.apache.org/jira/browse/SOLR-8135
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: Trunk
>            Reporter: Hoss Man
>         Attachments: SOLR-8135.failure.log, SOLR-8135.patch
>
>
> No idea what's going on here, noticed it while testing out an unrelated patch 
> -- seed reproduces against pristine trunk...
> {noformat}
>    [junit4]   2> NOTE: reproduce with: ant test  
> -Dtestcase=SolrCloudExampleTest 
> -Dtests.method=testLoadDocsIntoGettingStartedCollection 
> -Dtests.seed=59EA523FFF6CB60F -Dtests.slow=true -Dtests.locale=es_MX 
> -Dtests.timezone=Africa/Porto-Novo -Dtests.asserts=true 
> -Dtests.file.encoding=ISO-8859-1
>    [junit4] FAILURE 49.5s | 
> SolrCloudExampleTest.testLoadDocsIntoGettingStartedCollection <<<
>    [junit4]    > Throwable #1: java.lang.AssertionError: Delete action failed!
>    [junit4]    >      at 
> __randomizedtesting.SeedInfo.seed([59EA523FFF6CB60F:4A896050CE030FA9]:0)
>    [junit4]    >      at 
> org.apache.solr.cloud.SolrCloudExampleTest.doTestDeleteAction(SolrCloudExampleTest.java:169)
>    [junit4]    >      at 
> org.apache.solr.cloud.SolrCloudExampleTest.testLoadDocsIntoGettingStartedCollection(SolrCloudExampleTest.java:145)
>    [junit4]    >      at 
> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsFixedStatement.callStatement(BaseDistributedSearchTestCase.java:963)
>    [junit4]    >      at 
> org.apache.solr.BaseDistributedSearchTestCase$ShardsRepeatRule$ShardsStatement.evaluate(BaseDistributedSearchTestCase.java:938)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to