[ https://issues.apache.org/jira/browse/LUCENE-6835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130165#comment-15130165 ]
Dawid Weiss commented on LUCENE-6835: ------------------------------------- All the SVN branches are in git, you know that, Mike (right?). They're not branches, but they're tagged (so could be made branches again). This is the one you moved: history/branches/lucene-solr/lucene6835 I'd still create a new branch for the issue (since it's easier on the eyes as it doesn't reach SVN's convoluted merge history), but just a note for the future. For example you could have cherry picked all the commits from lucene6835 since it was forked from then-trunk. > Directory.deleteFile should "own" retrying deletions on Windows > --------------------------------------------------------------- > > Key: LUCENE-6835 > URL: https://issues.apache.org/jira/browse/LUCENE-6835 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Michael McCandless > Fix For: 5.5, Trunk > > Attachments: LUCENE-6835.patch > > > Rob's idea: > Today, we have hairy logic in IndexFileDeleter to deal with Windows file > systems that cannot delete still open files. > And with LUCENE-6829, where OfflineSorter now must deal with the situation > too ... I worked around it by fixing all tests to disable the virus checker. > I think it makes more sense to push this "platform specific problem" lower in > the stack, into Directory? I.e., its deleteFile method would catch the > access denied, and then retry the deletion later. Then we could re-enable > virus checker on all these tests, simplify IndexFileDeleter, etc. > Maybe in the future we could further push this down, into WindowsDirectory, > and fix FSDirectory.open to return WindowsDirectory on windows ... -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org