[
https://issues.apache.org/jira/browse/LUCENE-7010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130407#comment-15130407
]
Uwe Schindler commented on LUCENE-7010:
---------------------------------------
Sorry I still don't get it! In your patch, TestMergePolicyWrapper is the only
place that checks if all methods are overriden, but NoMergePolicy extends
MergePolicy and there is no TestNoMergePolicy. Could it be that your patch is
missing a file?
In any case I dont understand why this test should exist at all for
NoMergePolicy!?!
> Create MergePolicyWrapper
> -------------------------
>
> Key: LUCENE-7010
> URL: https://issues.apache.org/jira/browse/LUCENE-7010
> Project: Lucene - Core
> Issue Type: Improvement
> Components: core/index
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: LUCENE-7010.patch
>
>
> We currently have two MergePolicy implementations that are wrappers around
> another MP: {{SortingMergePolicy}} and {{UpgradeIndexMergePolicy}}. A
> {{MergePolicyWrapper}} will simplify building additional such wrapping MPs by
> delegating all method calls to the wrapped instance, and allowing
> implementations to override only what they need.
> Also, this issue removes the {{final}} modifier from MP public methods so
> that they can be delegated properly. See LUCENE-7008 for a test failure that
> uncovered this issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
