[ https://issues.apache.org/jira/browse/LUCENE-7012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130913#comment-15130913 ]
ASF subversion and git services commented on LUCENE-7012: --------------------------------------------------------- Commit 7c72c6a8913743c219fe82d8ebe91c1f8194d876 in lucene-solr's branch refs/heads/master from [~shaie] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7c72c6a ] LUCENE-7012: change license header location in new Java files > Change eclipse's "New Java Files" template to place the license header before > the package declaration > ----------------------------------------------------------------------------------------------------- > > Key: LUCENE-7012 > URL: https://issues.apache.org/jira/browse/LUCENE-7012 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Shai Erera > Assignee: Shai Erera > Attachments: LUCENE-7012.patch > > > Today the license header is placed after the package declaration. This > results in inconsistency in our files. In some the license is put after the > package and before the imports, in others it appears after the imports but > before class declaration and in others it appears in the middle of the > imports. > Also, when you e.g. "Organize Imports" in eclipse, if the header is located > in the middle of imports, it's sometimes completely removed from the file. > This issue is about changing the "New Java Files" template in eclipse so that > the license header is placed before the package declaration. This ensures > that "Organize Imports" doesn't mess with it, as well for new files (created > in eclipse), we will start getting some consistency. > If we also want to handle all current files by moving the license header > before the package, we can do so (I volunteer), but since it's a big change, > will likely do it over multiple commits and no need for an issue. BTW, if > anyone knows of a tool that can automate that, great. I found that Apache has > a perl script but it seems to only fix the header to the new format, yet not > moving it in the file. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org