[
https://issues.apache.org/jira/browse/SOLR-2337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006330#comment-13006330
]
Bill Bell edited comment on SOLR-2337 at 3/14/11 3:23 PM:
----------------------------------------------------------
There is one terminology issue with this patch:
1. If there are 20 rows that match your query and are grouped, and if rows=10,
then hits will be 10 (since the code does not loop through all results to short
circuit and speed up the results). Otherwise there could be a performance issue
with looping until end of results.
2. As normal, if there are 4 rows that match and are grouped, and you say
rows=10, hits will be 4 (normal behavior).
was (Author: billnbell):
The only downfall with this patch, is the hits=10 means the following:
1. if there are 20 rows that match and are grouped, and if rows=10 then hits
will be 10 (since the short circuit) is still obeyed. Otherwise there could be
a performance issue with looping until end of results.
2. if there are 4 rows that match and are grouped, and you say rows=10, hits
will be 4 (normal behavior).
> Solr needs hits= added to the log when using grouping
> ------------------------------------------------------
>
> Key: SOLR-2337
> URL: https://issues.apache.org/jira/browse/SOLR-2337
> Project: Solr
> Issue Type: Bug
> Components: SearchComponents - other
> Affects Versions: 4.0
> Reporter: Bill Bell
> Fix For: 4.0
>
> Attachments: SOLR.2337.patch
>
>
> We monitor the Solr logs to try to review queries that have hits=0. This
> enables us to improve relevancy since they are easy to find and review.
> When using group=true, hits= does not show up:
> {code}
> 2011-01-27 01:10:16,117 INFO core.SolrCore - [collection1] webapp=
> path=/select params={group=true&group.field=gender&group.field=id&q=*:*}
> status=0 QTime=15
> {code}
> The code in QueryComponent.java needs to add the matches() after calling
> grouping.execute() and add up the total.
> It does return hits= in the log for mainResult, but not for standard grouping.
> This should be easy to add since matches are defined...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
