[
https://issues.apache.org/jira/browse/SOLR-5730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143223#comment-15143223
]
Christine Poerschke commented on SOLR-5730:
-------------------------------------------
bq. What's the purpose of
enable="${solr.sortingMergePolicyFactory.enable:true}"?
Good catch. This used to be the enable attribute in the <sortMerges> element
alongside the <mergePolicy> element i.e.
{code}
<mergePolicy class="..."/>
<sortMerges enable="${solr.sortMerges.enable:false}">...</sortMerges>
{code}
but now that we have a combined {{<mergePolicyFactory
class="SortingMergePolicy">...</mergePolicyFactory>}} it doesn't really make
sense anymore. I will remove it.
bq. I kind of feel like the test you added to TestMiniSolrCloudCluster doesn't
belong in that class. Perhaps it should be in its own test class, inheriting
from this class, or just using MiniSolrCloudCluster?
I agree that {{TestMiniSolrCloudCluster}} has grown to have all sorts of test
methods which could be broken up somehow. SOLR-7886 exists to 'factor out a
TestMiniSolrCloudClusterBase class', initial discussion was in SOLR-7877, and
so for now I'd like to keep the short-ish {{testSegmentTerminateEarly}} method
in TestMiniSolrCloudCluster but I will try and see if the
{{TestSegmentTerminateEarlyState}} helper class with the longer logic can be
factored out into a class of its own.
> make Lucene's SortingMergePolicy and EarlyTerminatingSortingCollector
> configurable in Solr
> ------------------------------------------------------------------------------------------
>
> Key: SOLR-5730
> URL: https://issues.apache.org/jira/browse/SOLR-5730
> Project: Solr
> Issue Type: New Feature
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
> Labels: blocker
> Fix For: 5.5, master
>
> Attachments: SOLR-5730-part1and2.patch, SOLR-5730-part1of2.patch,
> SOLR-5730-part1of2.patch, SOLR-5730-part2of2.patch, SOLR-5730-part2of2.patch
>
>
> *Example configuration (solrconfig.xml) :*
> {noformat}
> -<mergePolicy class="TieredMergePolicy"/>
> +<mergePolicyFactory class="org.apache.solr.index.SortingMergePolicyFactory">
> + <str name="wrapped.prefix">in</str>
> + <str name="in.class">org.apache.solr.index.TieredMergePolicyFactory</str>
> + <str name="sort">timestamp desc</str>
> +</mergePolicyFactory>
> {noformat}
> *Example use (EarlyTerminatingSortingCollector):*
> {noformat}
> &sort=timestamp+desc&segmentTerminateEarly=true
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
