[
https://issues.apache.org/jira/browse/SOLR-8633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154788#comment-15154788
]
ASF subversion and git services commented on SOLR-8633:
-------------------------------------------------------
Commit 8cd53a076b579ebc3be1fbb26875321e66a41608 in lucene-solr's branch
refs/heads/master from markrmiller
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8cd53a0 ]
SOLR-8633: DistributedUpdateProcess processCommit/deleteByQuery call finish on
DUP and SolrCmdDistributor, which violates the lifecycle and can cause bugs.
> DistributedUpdateProcess.processCommit calls finish() - violates lifecycle,
> causes finish to be called twice (redundent code execution)
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8633
> URL: https://issues.apache.org/jira/browse/SOLR-8633
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Mark Miller
> Attachments: SOLR-8633.patch
>
>
> trying to wrap my head around a weird bug in my experiements with SOLR-445, i
> realized that {{DUP.processDelete}} has a direct call to {{finish()}}.
> This violates the normal lifecycle of an UpdateProcessor (finish is only
> suppose to be called exactly once after processing any/all UpdateCommands)
> and could potentially break any UpdateProcessors configured after DUP (or in
> my case: processors configured _before_ DUP that expect to be in charge of
> calling finish, and catching any resulting exceptions, as part of the normal
> life cycle)
> Independent of how it impacts other update processors, this also means that:
> # all the logic in {{DUP.doFinish}} is getting executed twice -- which seems
> kind of expensive/dangerous to me since there is leader initiated recovery
> involved in this method
> # {{SolrCmdDistributor.finish()}} gets called twice, which means
> {{StreamingSolrClients.shutdown()}} gets called twice, which means
> {{ConcurrentUpdateSolrClient.close()}} gets called twice ... it seems like
> we're just getting really lucky that (as configured by DUP) all of these
> resources are still usable after being finished/shutdown/closed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
