[ https://issues.apache.org/jira/browse/SOLR-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15159381#comment-15159381 ]
Scott Blum commented on SOLR-8696: ---------------------------------- Patch LGTM. On an unrelated note, I've never understood why it's so important to register all cores as down on startup, since presumably we're about to bring them all up.. > Start the Overseer before actions that need the overseer on init and when > reconnecting after zk expiration and improve init logic. > ---------------------------------------------------------------------------------------------------------------------------------- > > Key: SOLR-8696 > URL: https://issues.apache.org/jira/browse/SOLR-8696 > Project: Solr > Issue Type: Improvement > Components: SolrCloud > Affects Versions: 5.4.1 > Reporter: Scott Blum > Assignee: Mark Miller > Labels: patch, performance, solrcloud, startup > Attachments: SOLR-8696.patch, SOLR-8696.patch > > > ZkController.publishAndWaitForDownStates() occurs before overseer election. > That means if there is currently no overseer, there is ironically no one to > actually service the down state changes it's waiting on. This particularly > affects a single-node cluster such as you might run locally for development. > Additionally, we're doing an unnecessary ZkStateReader forced refresh on all > Overseer operations. This isn't necessary because ZkStateReader keeps itself > up to date. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org