[ https://issues.apache.org/jira/browse/LUCENE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163011#comment-15163011 ]
Robert Muir commented on LUCENE-7047: ------------------------------------- +1 we may want to followup with other issues/similar improvements like we have done to other point classes: * ensure this thing has simple unit tests testing the Geo3DPoint class itself. * ensure Geo3DPoint has a good toString() and test it * add javadocs link for your new static method in the class summary as a "list of supported operations" (even though its just one at the moment). See any of the other Points as an example. There is likely a lot of exposed surface (additional methods/members) from Field itself and it risks being hidden/disorganized otherwise. * test toString() of the returned shape query if not already tested. > Add Geo3DPoint.newShapeQuery > ---------------------------- > > Key: LUCENE-7047 > URL: https://issues.apache.org/jira/browse/LUCENE-7047 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Michael McCandless > Assignee: Michael McCandless > Fix For: master, 6.0 > > Attachments: LUCENE-7047.patch > > > This just fixes geo3d to match the other points APIs. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org