[ 
https://issues.apache.org/jira/browse/SOLR-5379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163757#comment-15163757
 ] 

Daniel Aitken commented on SOLR-5379:
-------------------------------------

Doesn't look like it from the patch, no; it's still using the extended synonym 
quoted query parser.

We have a client who requires matching on multi-word synonyms, so I've I've 
compiled Solr 4.10.3 with solr-5379-version-4.10.3.patch applied and have it up 
and running; just testing it now, with a kind of merged config between the unit 
test files provided in the patch and my regular Solr 4.x configuration.

Behaviour on quoted multi-word synonyms appears to work as expected across the 
testing I performed; this works well and would be fantastic to have available. 
I'm not too too concerned about drifting from edismax; unless I'm 
misunderstanding, wouldn't this solution maintain features from edismax by 
virtue of it being extended from it? It would be nice, however, not to maintain 
a custom query parser.

So, all in all, works well for us, but I am concerned about having to 
essentially maintain a fork of 4.10.3 just to support this one use case. Is 
there a possibility of this making it into a release? Is there anything else 
that needs to be done with it?

> Query-time multi-word synonym expansion
> ---------------------------------------
>
>                 Key: SOLR-5379
>                 URL: https://issues.apache.org/jira/browse/SOLR-5379
>             Project: Solr
>          Issue Type: Improvement
>          Components: query parsers
>            Reporter: Tien Nguyen Manh
>              Labels: multi-word, queryparser, synonym
>             Fix For: 4.9, master
>
>         Attachments: conf-test-files-4_8_1.patch, quoted-4_8_1.patch, 
> quoted.patch, solr-5379-version-4.10.3.patch, synonym-expander-4_8_1.patch, 
> synonym-expander.patch
>
>
> While dealing with synonym at query time, solr failed to work with multi-word 
> synonyms due to some reasons:
> - First the lucene queryparser tokenizes user query by space so it split 
> multi-word term into two terms before feeding to synonym filter, so synonym 
> filter can't recognized multi-word term to do expansion
> - Second, if synonym filter expand into multiple terms which contains 
> multi-word synonym, The SolrQueryParseBase currently use MultiPhraseQuery to 
> handle synonyms. But MultiPhraseQuery don't work with term have different 
> number of words.
> For the first one, we can extend quoted all multi-word synonym in user query 
> so that lucene queryparser don't split it. There are a jira task related to 
> this one https://issues.apache.org/jira/browse/LUCENE-2605.
> For the second, we can replace MultiPhraseQuery by an appropriate BoleanQuery 
> SHOULD which contains multiple PhraseQuery in case tokens stream have 
> multi-word synonym.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to