[ https://issues.apache.org/jira/browse/LUCENE-7053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171058#comment-15171058 ]
Robert Muir commented on LUCENE-7053: ------------------------------------- Yes, please, and remove BytesRef.COMPARATOR which just duplicates that: naturalOrder() already returns a singleton. Also in cases like TreeSet creation in the join tests, we should just make {{new TreeSet<>()}} and not pass any comparator in at all. > Remove deprecated BytesRef#getUTF8SortedAsUTF16Comparator() > ----------------------------------------------------------- > > Key: LUCENE-7053 > URL: https://issues.apache.org/jira/browse/LUCENE-7053 > Project: Lucene - Core > Issue Type: Improvement > Components: core/other > Reporter: Uwe Schindler > Assignee: Uwe Schindler > Fix For: master, 6.0 > > Attachments: LUCENE-7053.patch, LUCENE-7053.patch, LUCENE-7053.patch > > > Followup from LUCENE-7052: This removes the legacy, deprecated > getUTF8SortedAsUTF16Comparator() in the BytesRef class. The only left over > user was TSTLookup. Moves the code there as private impl detail. > This also converts the comparators to lambdas for better readability. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org