[
https://issues.apache.org/jira/browse/SOLR-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Rowe updated SOLR-8778:
-----------------------------
Attachment: SOLR-8778.patch
Patch implementing the idea, additionally adding a ctor param for
{{printerNewline}} and deprecating {{clone()}}, which will also be removed
(along with {{implements Cloneable}}) in Solr 7, since the sequence
(clone(),setXXX(), ...) will no longer be supported - people will just create
new immutable instances using one of the ctors.
I guess a builder would make sense here, since there are now 9 params in the
full ctor, but I don't plan on doing that.
I'll make a followup issue to remove the deprecated stuff in master.
Precommit passes, along with the unit tests in the same package. Running the
full Solr test suite now, once done, assuming no failures, I'll commit.
> Deprecate CSVStrategy's setters, and make its pre-configured strategies
> immutable
> ---------------------------------------------------------------------------------
>
> Key: SOLR-8778
> URL: https://issues.apache.org/jira/browse/SOLR-8778
> Project: Solr
> Issue Type: Bug
> Reporter: Steve Rowe
> Attachments: SOLR-8778.patch
>
>
> Removing some deprecated things in CSVStrategy (SOLR-8764) exposed a bug:
> it's possible to redefine the public static
> {{CSVStrategy.\{DEFAULT,EXCEL,TDF}_STRATEGY}} strategies, simply by calling
> their setters.
> Right now that's happening in {{CSVParserTest.testUnicodeEscape()}}, where
> the default unicode escape interpretation is changed from false to true. And
> then if that test happens to run before
> {{CSVStrategyTest.testSetCSVStrategy()}}, which tests that the unicode escape
> interpretation on the default strategy is set to false, then the latter will
> fail.
> Example failures:
> http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/16079/ and
> http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-MacOSX/3126/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
