[
https://issues.apache.org/jira/browse/SOLR-8778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15178593#comment-15178593
]
Uwe Schindler commented on SOLR-8778:
-------------------------------------
bq. I'll hold off creating a JIRA to remove the deprecated stuff in master,
since as Uwe says we should instead remove the whole fork.
We should investigate this. Issue with patch is SOLR-3213, but I gave up
because to fix this you have to understand the whole CSV handler code (and I
was not familar to it when I tried to do this).
> Deprecate CSVStrategy's setters, and make its pre-configured strategies
> immutable
> ---------------------------------------------------------------------------------
>
> Key: SOLR-8778
> URL: https://issues.apache.org/jira/browse/SOLR-8778
> Project: Solr
> Issue Type: Bug
> Reporter: Steve Rowe
> Assignee: Steve Rowe
> Fix For: master, 6.0
>
> Attachments: SOLR-8778.patch
>
>
> Removing some deprecated things in CSVStrategy (SOLR-8764) exposed a bug:
> it's possible to redefine the public static
> {{CSVStrategy.\{DEFAULT,EXCEL,TDF}_STRATEGY}} strategies, simply by calling
> their setters.
> Right now that's happening in {{CSVParserTest.testUnicodeEscape()}}, where
> the default unicode escape interpretation is changed from false to true. And
> then if that test happens to run before
> {{CSVStrategyTest.testSetCSVStrategy()}}, which tests that the unicode escape
> interpretation on the default strategy is set to false, then the latter will
> fail.
> Example failures:
> http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-Linux/16079/ and
> http://jenkins.thetaphi.de/job/Lucene-Solr-trunk-MacOSX/3126/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
