[
https://issues.apache.org/jira/browse/LUCENE-7063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-7063:
--------------------------------
Attachment: LUCENE-7063.patch
Updated patch: adds TestNumericUtils.
I was surprised this class was missing entirely!
I "ported" many methods from TestLegacyNumericUtils to the new encodings: these
test round-trip, compare, explicitly test "special" values for each type. I
added BigInteger versions of each too.
I also added random tests for each type (including bigint) that just do simple
round-tripping and comparisons.
There were tests for NumericUtils binary add() and subtract() methods, but
these were in TestBKD! I moved those to this test, too.
> NumericUtils vs LegacyNumericUtils chaos with 6.0
> -------------------------------------------------
>
> Key: LUCENE-7063
> URL: https://issues.apache.org/jira/browse/LUCENE-7063
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-7063.patch, LUCENE-7063.patch
>
>
> Old prefix-coded terms helper functions are still available in
> LegacyNumericUtils, but its confusing when upgrading because NumericUtils and
> LegacyNumericUtils have overlaps in the APIs.
> One issue is they share some exact methods that are completely unrelated to
> this encoding (e.g. floatToSortableInt). The method is just duplication and
> worst, most lucene code is still calling it from LegacyNumericUtils, even
> stuff like faceting code using it with docvalues.
> Another issue is the new NumericUtils methods (which use full byte range)
> have vague names, no javadocs, expose helper methods as public unnecessarily,
> and cause general confusion.
> I don't think NumericUtils and LegacyNumericUtils should overlap.
> LegacyNumericUtils should only contain legacy stuff!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
